-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Add changelog for date range picker aria-disabled updates [#6013] #2817
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick fix for the PR number and this should be good to go 👍
@@ -2,6 +2,14 @@ title: Date picker | |||
type: component | |||
changelogURL: | |||
items: | |||
- date: NNNN-NN-NN | |||
summary: Added `aria-disabled` to the list of expected attributes. | |||
summaryAdditional: Now, the component will disable toggle when the `aria-disabled` attribute is present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Should we mention that the input
is disabled as well?
summaryAdditional: Now, the component will disable toggle when the `aria-disabled` attribute is present. | |
summaryAdditional: Now, the component will disable the text input and calendar toggle when the `aria-disabled` attribute is present. |
Oh it looks like we have two PRs for the same work. This and #2794. We generally only need one changelog PR for each USWDS PR. Even though this is a second changelog/component, we can bundle both changes in one PR. #2794 seems to have more discussion so I opt we close this PR in favor of that one, and bring the date range picker changes there! |
Summary
This PR provides a changelog entry for the updates made to the date range picker component. The
readonly
attribute has been added toaria-disabled
to mimic the disabled behaviors while remaining discoverable for accessibility purposes.Related issue
USWDS - Date Picker: Updated toggleCalendar function to account for aria-disabled attribute + readonly #6013
Preview link
USWDS-Site: Date Range Picker
Testing and review