USWDS web-components: Configure publication to NPM #62
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
reviewed
Aug 29, 2024
There was a problem hiding this comment.
@heymatthenry looking forward to seeing this included in this repo and others, thank you!
Minor comment on what triggers the release. Our current release process includes GitHub releases and then publishing to NPM. The nice thing about it is that we can thoroughly document and provide a good changelog.
Open to other ideas and iterating on this if we simply want to test the action.
| node-version: '20.x' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - run: npm ci | ||
| - run: npm publish --provenance --access public --tag develop |
There was a problem hiding this comment.
praise: Provenance flag is a great idea!
| on: | ||
| push: | ||
| branches: | ||
| - develop |
There was a problem hiding this comment.
question: Should this be on [published] or main?
Going off of example workflow guidance:
name: Publish package to GitHub Packages
on:
release:
types: [published]
…
mejiaj
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Configured package for publication and created a workflow to automatically publish to
@uswds/web-components@developon pushes todevelop