Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate listenTCP without explictly stating the network interface #2087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wilzbach
Copy link
Member

See also: #2081 (comment)

My thoughts

  • if it's always required, listenTCP("127.0.0.1", 8080, ...) would be nicer to read
  • maybe listenTCP can support a similar shorthand like listenHTTP does (e.g. listenTCP(":8080") or listenTCP("127.0.0.1:8080")
  • TCPListenOptions and address seem to overload a bit and options is just an enum (just in case more options are added in the future) so it might make sense to do the change once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant