Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan Archives #3

Open
abn opened this issue Dec 11, 2013 · 2 comments
Open

Scan Archives #3

abn opened this issue Dec 11, 2013 · 2 comments
Assignees

Comments

@abn
Copy link
Member

abn commented Dec 11, 2013

We need to consider handling ZIP and TAR files for scans.

Maybe RPM too?

@ghost ghost assigned gcmurphy Dec 11, 2013
@gcmurphy
Copy link
Contributor

I agree that this is something worth considering. Although I am concerned about is scope creep. e.g. Do we also include .deb files? .rar?

One thing worth considering is that the three file formats that you've mentioned all can be unpacked to stdout e.g. for tar files. So perhaps a general solution could include an option to receive file content from stdin via a special flag.

rpm2cpio example.rpm | cpio --to-stdout -iv | java -jar victims-client.jar --pipe

However there are numerous headaches that would come from this also. I'll put this on the todo list I'm not certain what the best way to tackle this is right now.

@abn
Copy link
Member Author

abn commented Dec 12, 2013

Scope creep is an issue yes, however for a standalone client I reckon we need to at the very least support the handling of ZIP archives.

The rest I suppose can be handled via a stdin based scanner. Although it might be good to design it in such a way that new scanners can be plugged in with stdin and zip being the first ones. We can expand later if/when the need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants