Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(acessibility): the favorite button does not have an accessible name #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joaocore
Copy link

Adicionado texto ao span, pois o Lighthouse está acusando o problema "Os botões não têm um nome acessível".
Como deve ser exibido apenas um ícone, foi adicionado font-size: 0 para não ser exibido o texto adicionado ao span.

Workspace com ajuste

Atualmente:
image

Lighthouse:
image

Com ajuste:
image
image

Lighthouse:
image

O item "Os botões não têm um nome acessível" deixou de ser exibido.

Copy link

vtex-io-ci-cd bot commented Jun 24, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@joaocore
Copy link
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant