Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes mark from components/sections #2478

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Sep 26, 2024

What's the purpose of this pull request?

This PR is part of the Performance epic and aims to remove the mark from our components and sections. It also removes the mark from the tests (they were being skipped).

Starters Deploy Preview

PSI Snapshot

Screenshot 2024-09-26 at 17 30 00

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:11pm

@eduardoformiga eduardoformiga marked this pull request as ready for review September 26, 2024 20:10
@eduardoformiga eduardoformiga requested a review from a team as a code owner September 26, 2024 20:10
@eduardoformiga eduardoformiga requested review from hellofanny and pedromtec and removed request for a team September 26, 2024 20:10
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Nice!
~ housekeeping

@hellofanny
Copy link
Contributor

obs: This task looks more like a chore? 👀

@eduardoformiga
Copy link
Member Author

obs: This task looks more like a chore? 👀

yes, I'll update the title 😉

@eduardoformiga eduardoformiga changed the title feat: removes mark from components/sections chore: removes mark from components/sections Sep 27, 2024
@eduardoformiga eduardoformiga merged commit 9abc0dd into main Sep 27, 2024
7 checks passed
@eduardoformiga eduardoformiga deleted the feat/SFS-1455-remove-mark-from-sections branch September 27, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Pull requests related to perfomance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants