Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that the CRD is up to date on each PR #246

Open
yersan opened this issue Nov 18, 2022 · 0 comments
Open

Check that the CRD is up to date on each PR #246

yersan opened this issue Nov 18, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@yersan
Copy link
Collaborator

yersan commented Nov 18, 2022

The CRD must be generated when you need to deploy the Operator in your cluster. The make target to generate it is the following one:

(main): $ make manifests

The CRD is generated at wildfly-operator/config/crd/bases/wildfly.org_wildflyservers.yaml

(0.5.x): $ ./operator-sdk generate crds or $ make codegen

The CRD is generated at wildfly-operator/deploy/crds/wildfly.org_wildflyservers_crd.yaml

We have to ensure that the CRD is always up to date and fail to accept the PR in such a case. At first glance, it seems a custom GitHub action could do this kind of work.
@yersan yersan added the good first issue Good for newcomers label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yersan