From 9ae122a4fdb94ba48a757dafa71c159444d30412 Mon Sep 17 00:00:00 2001 From: Opeyemi Ibrahim Date: Tue, 28 May 2024 11:13:24 +0100 Subject: [PATCH 1/7] :closes: Add attribute to preload element #6672 --- inc/Engine/Media/AboveTheFold/Frontend/Controller.php | 2 +- inc/Engine/Optimization/GoogleFonts/AbstractGFOptimization.php | 2 +- inc/Engine/Optimization/RUCSS/Controller/UsedCSS.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/inc/Engine/Media/AboveTheFold/Frontend/Controller.php b/inc/Engine/Media/AboveTheFold/Frontend/Controller.php index 58d110e9c8..550425216f 100644 --- a/inc/Engine/Media/AboveTheFold/Frontend/Controller.php +++ b/inc/Engine/Media/AboveTheFold/Frontend/Controller.php @@ -244,7 +244,7 @@ private function generate_lcp_link_tag_with_sources( $lcp ): array { } $tag = ''; - $start_tag = '', // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedStylesheet + '', // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedStylesheet $url ); } diff --git a/inc/Engine/Optimization/RUCSS/Controller/UsedCSS.php b/inc/Engine/Optimization/RUCSS/Controller/UsedCSS.php index 24be25a08c..b9bef132ed 100644 --- a/inc/Engine/Optimization/RUCSS/Controller/UsedCSS.php +++ b/inc/Engine/Optimization/RUCSS/Controller/UsedCSS.php @@ -615,7 +615,7 @@ private function preload_links( array $urls ): string { $links = ''; foreach ( $urls as $url ) { - $links .= ''; + $links .= ''; } return $links; From 1629b0571476e932b28f17b9e0f3a32b13718039 Mon Sep 17 00:00:00 2001 From: Opeyemi Ibrahim Date: Tue, 28 May 2024 12:21:58 +0100 Subject: [PATCH 2/7] Update existing test --- ...tput_lcp_bg_responsive_imgset_template.php | 2 +- ...tput_lcp_bg_responsive_webkit_template.php | 2 +- .../Subscriber/HTML/output_lcp_layered_bg.php | 2 +- .../Subscriber/HTML/output_lcp_picture.php | 2 +- .../Subscriber/HTML/output_lcp_responsive.php | 2 +- .../Subscriber/HTML/output_lcp_single_bg.php | 2 +- .../HTML/output_w_bg_image_lcp.html | 2 +- .../Subscriber/HTML/output_w_img_lcp.html | 2 +- .../HTML/output_w_picture_img_lcp.html | 2 +- .../Subscriber/HTML/output_w_preload.html | 2 +- .../GoogleFonts/Combine/optimize.php | 26 +++++++++---------- .../GoogleFonts/CombineV1V2/optimize.php | 20 +++++++------- .../GoogleFonts/CombineV2/optimize.php | 12 ++++----- .../Subscriber/HTML/outputFontExcluded.html | 2 +- .../Subscriber/HTML/outputFontPreloaded.html | 2 +- 15 files changed, 41 insertions(+), 41 deletions(-) diff --git a/tests/Fixtures/inc/Engine/Media/AboveTheFold/Frontend/Subscriber/HTML/output_lcp_bg_responsive_imgset_template.php b/tests/Fixtures/inc/Engine/Media/AboveTheFold/Frontend/Subscriber/HTML/output_lcp_bg_responsive_imgset_template.php index 68f7551be0..ba489b5c19 100644 --- a/tests/Fixtures/inc/Engine/Media/AboveTheFold/Frontend/Subscriber/HTML/output_lcp_bg_responsive_imgset_template.php +++ b/tests/Fixtures/inc/Engine/Media/AboveTheFold/Frontend/Subscriber/HTML/output_lcp_bg_responsive_imgset_template.php @@ -8,7 +8,7 @@ - lcp_bg_responsive_template + lcp_bg_responsive_template