Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units of work on Emacs Keymap are too granular #1086

Open
RubenAstudillo opened this issue Jun 9, 2018 · 0 comments
Open

Units of work on Emacs Keymap are too granular #1086

RubenAstudillo opened this issue Jun 9, 2018 · 0 comments

Comments

@RubenAstudillo
Copy link

When launching with the Emacs keymap, every single key that is inserted on the buffer is added as an Insert event on the undo/redo list. To check this launch yi, write "hello world and foo bar" and the press C-x u a few times, it will be clear what I am meaning.

As a consequence of how the Keymap is implemented, via the Alternative instance of KeymapM () it is not clear where we should startUpdateTranssaction to re-use the machinery already at work on the undo/redo system with the vim keymap. The algorithm of how Emacs determines an unit of work is given here.

@RubenAstudillo RubenAstudillo changed the title Units of work on Emacs Keymap are to granular Units of work on Emacs Keymap are too granular Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant