Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Yi.Keymap.Cua from Yi.Keymap.Emacs #1100

Open
waivio opened this issue Oct 28, 2018 · 1 comment
Open

Decouple Yi.Keymap.Cua from Yi.Keymap.Emacs #1100

waivio opened this issue Oct 28, 2018 · 1 comment

Comments

@waivio
Copy link

waivio commented Oct 28, 2018

I believe that my distro is having issues packaging Yi.Keymap.Cua because of it's dependency on the Emacs keymap. I was thinking of helping resolve this by making a Yi.Keymap.Cua.KillRing and Yi.Keymap.Cua.Utils duplicating the code from the Yi.Keymap.Emacs.KillRing and Yi.Keymap.Cua.Utils. I've made these simple changes and updated the cabal file and it seems to compile. Should I generate a pull request? Or should the KillRing and Utils code be refactored somewhere else?

@codygman
Copy link

@waivio I'm not very involved in the Yi project, but in general it's better to submit a PR and your question at the same time so everyone can see the code too. Worst case scenario is that your PR is closed, but even closed PR's could be useful to someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants