Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users about resources when using the plugin with large systems #4

Open
yiquintero opened this issue Jul 5, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request LAMMPS Changes requested by LAMMPS dev team

Comments

@yiquintero
Copy link
Owner

yiquintero commented Jul 5, 2023

Description

From the LAMMPS plugin review:

Overall, this would be a contribution that needs to explicitly warn about the growing memory use and performance impact of applying it for larger systems, since it will cancel parallelization and data distribution.

Solution

  1. Obtain a set of LAMMPS input files to benchmark the plugin
    Define a system that can be easily modified to vary the amount of time steps and total number of particles. The plugin should be used to calculate the 4 quantities and, ideally, the calls to OCTP should be easy to comment-off from the LAMMPS input file.

  1. Measure memory consumption and wall-time introduced by the plugin

    1. Run the simulation of each input file and measure the wall-time and memory consumption.
    2. Remove the calls to OCTP from the input files and run the simulations again, also taking note of the wall-time and memory consumption.
    3. Make the following plots:
      a. number of particles vs execution time
      b. number of particles vs memory consumption
      c. time steps vs execution time
      d. time steps vs memory consumption
    4. Based on the information in the plots, determine the number of particles and time steps that should warrant a warning to the user.
  2. Determine the best way to warn users about increasing memory resources and execution times.
    A few ideas: Include plots and message in README file, write a message to the LAMMPS simulation log file.

@yiquintero yiquintero added enhancement New feature or request LAMMPS Changes requested by LAMMPS dev team labels Jul 6, 2023
@yiquintero yiquintero self-assigned this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LAMMPS Changes requested by LAMMPS dev team
Projects
None yet
Development

No branches or pull requests

1 participant