Make asyncMap to prevent from race-condition #1492
Closed
+19
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
commented
Aug 7, 2024
| @@ -89,12 +89,13 @@ public class Glob: Collection { | |||
| } | |||
|
|
|||
| let patterns = behavior.supportsGlobstar ? expandGlobstar(pattern: adjustedPattern) : [adjustedPattern] | |||
|
|
|||
|
|
|||
| let isIncludingFiles = includeFiles | |||
There was a problem hiding this comment.
This closure made @Sendable closure, so it's better to avoid passing mutable variables
freddi-kit
reviewed
Aug 7, 2024
Comment on lines
+6
to
+10
| var buffer = ContiguousArray<T?>(repeating: nil, count: count) | ||
| DispatchQueue.concurrentPerform(iterations: count) { idx in | ||
| buffer[idx] = transform(self[idx]) | ||
| } | ||
| return buffer.map { $0! } |
There was a problem hiding this comment.
tab/space is not unified
giginet
commented
Aug 7, 2024
| func parallelMap<T>(transform: @Sendable (Element) -> T) -> [T] { | ||
| var buffer = ContiguousArray<T?>(repeating: nil, count: count) | ||
| DispatchQueue.concurrentPerform(iterations: count) { idx in | ||
| buffer[idx] = transform(self[idx]) |
There was a problem hiding this comment.
This implementation is dangerous, it may cause a race-condition...
|
This PR seems to pass the test and builds, but I'm concerned that this change is breaking thread-safe... 🤔 The best solution is to replace the modern concurrency mechanism, but it's tough to introduce Swift Concurrency to this project. |
|
This issue seems to be fixed on Beta 6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1491
Build failure due to concurrency issue since Xcode 16 Beta 5 · Issue #1491 · yonaskolb/XcodeGen
The current main can't build with Xcode 16 Beta 5.
Because,
UnsafeMutableBudderPointeris not a thread-safe, so we can't pass it toSendableclosure even if compiled in Swift 5 mode.This PR resolves this issue.
This change may cause the performance, but I have no idea how much not using
ContiguousArraywill affect performance