Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct interpretation of controller capability flags #7145

Open
AlCalzone opened this issue Sep 4, 2024 · 0 comments
Open

Correct interpretation of controller capability flags #7145

AlCalzone opened this issue Sep 4, 2024 · 0 comments

Comments

@AlCalzone
Copy link
Member

Some investigation shows those are quite a mess and don't work as advertised.

grafik

The IS_PRIMARY and IS_SIS flags of the GetSerialApiInitData response don't seem to work as advertised.
IS_SIS is true when the current controller is or used to be the primary, and is the SIS. It's false on secondaries that have been assigned the SIS role. It's also incorrect when there are no other nodes on the network. Even when the primary controller has set itself as SIS, IS_SIS == 0.

IS_PRIMARY I cannot really make sense of. It does not indicate a primary controller. IS_REAL_PRIMARY does this.
When IS_REAL_PRIMARY is false, IS_SECONDARY can be used to distinguish true secondary controllers (cannot include/exclude nodes) and inclusion controllers.

The SIS does not have to be the primary controller, unlike the documentation states. After shifting the primary role from the SIS to a secondary, the SIS role stays on the former primary - now inclusion controller?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant