fix(lsp): nested call expressions #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a0bf5be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
May 13, 2024
| @@ -158,7 +158,7 @@ export const resolveTadaFragmentArray = ( | |||
| if (node.elements.every(ts.isIdentifier)) return node.elements; | |||
| const identifiers: ts.Identifier[] = []; | |||
| for (let element of node.elements) { | |||
| while (ts.isPropertyAccessExpression(element)) element = element.expression; | |||
| while (ts.isPropertyAccessExpression(element)) element = element.name; | |||
There was a problem hiding this comment.
This looks like it was refactored the wrong way, if we keep accessing the expression we'll reach the top-element i.e. fields.fragment we'll get fields rather than fragment
JoviDeCroock
force-pushed
the
fix-nested-call-expressions
branch
from
db8418a
to
c1c9ff4
Compare
JoviDeCroock
force-pushed
the
fix-nested-call-expressions
branch
from
c1c9ff4
to
b37d135
Compare
kitten
approved these changes
May 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for inline defined graphql-strings, auto-complete and quick-info always worked however diagnostics/... did not.
This is slightly less performant as we traverse deeper but seems worth it
Fixes #316