Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hls player ui for mweb #2446

Merged
merged 27 commits into from
Feb 27, 2024
Merged

feat: hls player ui for mweb #2446

merged 27 commits into from
Feb 27, 2024

Conversation

amar-1995
Copy link
Member

@amar-1995 amar-1995 commented Jan 21, 2024 •
edited
Loading

Details(context, link the issue, how was the bug fixed, what does the new feature do)

  • Landscape view for hls player
  • Portrait view for hls player
  • Chat and Poll ui updation
  • Action on leave button
  • Remove footer and header.

Implementation note, gotchas, related work and Future TODOs (optional)

  • Portrait view
  • Landscape view
  • Remove footer and header

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 0:32am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 0:32am

@amar-1995 amar-1995 marked this pull request as ready for review February 27, 2024 10:58
@raviteja83 raviteja83 merged commit b5ea0d8 into main Feb 27, 2024
4 of 5 checks passed
@raviteja83 raviteja83 deleted the WEB-2554-hls-player-mweb branch February 27, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviteja83 raviteja83 raviteja83 approved these changes

@KaustubhKumar05 KaustubhKumar05 Awaiting requested review from KaustubhKumar05 KaustubhKumar05 is a code owner

@eswarclynn eswarclynn Awaiting requested review from eswarclynn eswarclynn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amar-1995 @raviteja83 @KaustubhKumar05