fix: stream reloading on polls change #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviteja83
requested review from
eswarclynn,
amar-1995 and
KaustubhKumar05
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amar-1995
previously approved these changes
Mar 4, 2024
KaustubhKumar05
previously approved these changes
Mar 4, 2024
KaustubhKumar05
previously approved these changes
Mar 4, 2024
KaustubhKumar05
previously approved these changes
Mar 4, 2024
KaustubhKumar05
approved these changes
Mar 4, 2024
KaustubhKumar05
added a commit
that referenced
this pull request
Mar 4, 2024
* fix: disable pip for hls stream * fix: stream reloading on polls change (#2639) * fix: stream reloading on polls change * fix: toggle chat before stream start * fix: show chat when polls closed * fix: chat toggle after closing poll * fix: role options crash * fix: cross icon on stream ended * fix: fullscreen height in mweb --------- Co-authored-by: KaustubhKumar05 <[email protected]> --------- Co-authored-by: Amar Bathwal <[email protected]> Co-authored-by: Ravi theja <[email protected]> Co-authored-by: KaustubhKumar05 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details(context, link the issue, how was the bug fixed, what does the new feature do)
Implementation note, gotchas, related work and Future TODOs (optional)