Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: frozen stats #2646

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: frozen stats #2646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16e881f
fix: do not create sample when stats are empty
eswarclynn Mar 4, 2024
e501cb3
fix: delete track analytics when track is stopped
eswarclynn Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/hms-video-store/src/analytics/stats/BaseStatsAnalytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ export abstract class RunningTrackAnalytics {
}

createSample() {
if (this.tempStats.length === 0) {
return;
}

this.samples.push(this.collateSample());
this.tempStats.length = 0;
}
Expand Down
7 changes: 7 additions & 0 deletions packages/hms-video-store/src/analytics/stats/PublishStatsAnalytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ export class PublishStatsAnalytics extends BaseStatsAnalytics {
});
});

// delete track analytics if track is not present in store and no samples are present
this.trackAnalytics.forEach(trackAnalytic => {
if (!this.store.hasTrack(trackAnalytic.track) && !(trackAnalytic.samples.length > 0)) {
this.trackAnalytics.delete(trackAnalytic.track_id);
}
});

if (shouldCreateSample) {
this.trackAnalytics.forEach(trackAnalytic => {
trackAnalytic.createSample();
Expand Down
7 changes: 7 additions & 0 deletions packages/hms-video-store/src/analytics/stats/SubscribeStatsAnalytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ export class SubscribeStatsAnalytics extends BaseStatsAnalytics {
}
});

// delete track analytics if track is not present in store and no samples are present
this.trackAnalytics.forEach(trackAnalytic => {
if (!this.store.hasTrack(trackAnalytic.track) && !(trackAnalytic.samples.length > 0)) {
this.trackAnalytics.delete(trackAnalytic.track_id);
}
});

if (shouldCreateSample) {
this.trackAnalytics.forEach(trackAnalytic => {
trackAnalytic.createSample();
Expand Down
Loading