Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: design parity for hand raise actions #2694

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix: design parity for hand raise actions #2694

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcab3d3
fix: design parity
KaustubhKumar05 Mar 12, 2024
963bd49
fix: move constant value out of the component
KaustubhKumar05 Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions packages/roomkit-react/src/Prebuilt/components/Footer/ParticipantList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ import {
SearchIcon,
VerticalMenuIcon,
} from '@100mslive/react-icons';
import { Accordion, Box, config as cssConfig, Dropdown, Flex, Input, Text, textEllipsis } from '../../..';
import { IconButton as BaseIconButton } from '../../../IconButton';
import { Accordion, Box, Button, config as cssConfig, Dropdown, Flex, Input, Text, textEllipsis } from '../../..';
// @ts-ignore: No implicit Any
import IconButton from '../../IconButton';
import { ConnectionIndicator } from '../Connection/ConnectionIndicator';
Expand Down Expand Up @@ -324,21 +323,16 @@ const HandRaisedAccordionParticipantActions = ({ peerId, role }: { peerId: strin
peerId,
role,
});
const quickActionStyle = { p: '$1', borderRadius: '$round' };
KaustubhKumar05 marked this conversation as resolved.
Show resolved Hide resolved
return (
<>
<BaseIconButton
css={{ p: '$1', c: '$on_surface_high', bg: '$surface_bright', borderRadius: '$round' }}
onClick={() => lowerPeerHand()}
>
<CrossIcon height={19} width={19} />
</BaseIconButton>
<Button variant="standard" css={quickActionStyle} onClick={lowerPeerHand}>
<CrossIcon height={18} width={18} />
</Button>
{shouldShowStageRoleChange && !isInStage && (
<BaseIconButton
css={{ p: '$1', c: '$on_surface_high', bg: '$primary_default', borderRadius: '$round' }}
onClick={() => handleStageAction()}
>
<AddIcon height={19} width={19} />
</BaseIconButton>
<Button variant="primary" onClick={handleStageAction} css={quickActionStyle}>
<AddIcon height={18} width={18} />
</Button>
)}
</>
);
Expand Down
12 changes: 8 additions & 4 deletions packages/roomkit-react/src/Prebuilt/components/Footer/RoleAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useEffect } from 'react';
import { useMeasure } from 'react-use';
import { FixedSizeList } from 'react-window';
import { HMSPeer, selectIsLargeRoom, useHMSStore, usePaginatedParticipants } from '@100mslive/react-sdk';
import { ChevronRightIcon } from '@100mslive/react-icons';
import { AddIcon, ChevronRightIcon, CrossIcon } from '@100mslive/react-icons';
import { Accordion } from '../../../Accordion';
import { Button } from '../../../Button';
import { HorizontalDivider } from '../../../Divider';
Expand Down Expand Up @@ -152,10 +152,14 @@ export const RoleAccordion = ({
<>
<HorizontalDivider />
<Flex css={{ w: '100%', p: '$6', gap: '$4' }} justify="center">
<Button variant="standard" onClick={() => lowerAllHands()}>
Lower All Hands
<Button variant="standard" onClick={lowerAllHands} icon css={{ pl: '$2' }}>
<CrossIcon /> Lower All Hands
</Button>
{canBringToStage && <Button onClick={() => bringAllToStage()}>{bring_to_stage_label}</Button>}
{canBringToStage && (
<Button onClick={bringAllToStage} icon css={{ pl: '$2' }}>
<AddIcon /> {bring_to_stage_label}
</Button>
)}
</Flex>
</>
)}
Expand Down
Loading