fix: make hls player take more space when in fullscreen #3258

amar-1995 · 2024-09-10T07:42:17Z

Issues:

Video quality popup not working in fullscreen mode.
Volume slider is taking value in decimal
Managing the width and height of a video based on its aspect ratio.

vercel · 2024-09-10T07:42:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 13, 2024 7:27am
storybook-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 13, 2024 7:27am

examples/prebuilt-react-integration/src/App.jsx

packages/hls-player/src/controllers/HMSHLSPlayer.ts

packages/roomkit-react/src/Prebuilt/components/HMSVideo/HMSVideo.jsx

packages/roomkit-react/src/Prebuilt/layouts/HLSView.jsx

amar-1995 added 3 commits September 10, 2024 12:16

fix: hls player bug fixes

799fdea

fix: added width and height

fb126cb

fix: height based on width

5b296ab

amar-1995 requested review from raviteja83, eswarclynn and KaustubhKumar05 as code owners September 10, 2024 07:42

vercel bot deployed to Preview – dashboard-app September 10, 2024 07:45 View deployment

vercel bot deployed to Preview – storybook-app September 10, 2024 07:46 View deployment

fix: remove unset height

d5ea8bb

vercel bot deployed to Preview – dashboard-app September 10, 2024 07:53 View deployment

vercel bot deployed to Preview – storybook-app September 10, 2024 07:54 View deployment

fix: added full screen height

cc476ce

vercel bot deployed to Preview – dashboard-app September 10, 2024 09:27 View deployment

fix: added null check

de922bb

vercel bot deployed to Preview – dashboard-app September 10, 2024 09:31 View deployment

vercel bot deployed to Preview – storybook-app September 10, 2024 09:32 View deployment

KaustubhKumar05 reviewed Sep 13, 2024

View reviewed changes

examples/prebuilt-react-integration/src/App.jsx Outdated Show resolved Hide resolved

packages/hls-player/src/controllers/HMSHLSPlayer.ts Outdated Show resolved Hide resolved

raviteja83 reviewed Sep 13, 2024

View reviewed changes

packages/roomkit-react/src/Prebuilt/components/HMSVideo/HMSVideo.jsx Outdated Show resolved Hide resolved

raviteja83 reviewed Sep 13, 2024

View reviewed changes

packages/roomkit-react/src/Prebuilt/components/HMSVideo/HMSVideo.jsx Outdated Show resolved Hide resolved

raviteja83 reviewed Sep 13, 2024

View reviewed changes

packages/roomkit-react/src/Prebuilt/components/HMSVideo/HMSVideo.jsx Outdated Show resolved Hide resolved

raviteja83 reviewed Sep 13, 2024

View reviewed changes

packages/roomkit-react/src/Prebuilt/layouts/HLSView.jsx Outdated Show resolved Hide resolved

fix: hls player pr comment

4f17372

amar-1995 requested review from raviteja83 and KaustubhKumar05 September 13, 2024 07:04

vercel bot deployed to Preview – dashboard-app September 13, 2024 07:06 View deployment

vercel bot deployed to Preview – storybook-app September 13, 2024 07:07 View deployment

fix: variable name

b947aa4

vercel bot deployed to Preview – dashboard-app September 13, 2024 07:26 View deployment

vercel bot deployed to Preview – storybook-app September 13, 2024 07:27 View deployment

raviteja83 approved these changes Sep 13, 2024

View reviewed changes

raviteja83 changed the title ~~fix: hls player issue~~ fix: make hls player take more space when in fullscreen Sep 13, 2024

KaustubhKumar05 approved these changes Sep 13, 2024

View reviewed changes

amar-1995 merged commit 3af7440 into dev Sep 13, 2024
4 checks passed

amar-1995 deleted the fix/WEB-3014-hls-player-issue branch September 13, 2024 11:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: make hls player take more space when in fullscreen #3258

fix: make hls player take more space when in fullscreen #3258

amar-1995 commented Sep 10, 2024 •

edited

Loading

vercel bot commented Sep 10, 2024 •

edited

Loading

fix: make hls player take more space when in fullscreen #3258

fix: make hls player take more space when in fullscreen #3258

Conversation

amar-1995 commented Sep 10, 2024 • edited Loading

vercel bot commented Sep 10, 2024 • edited Loading

amar-1995 commented Sep 10, 2024 •

edited

Loading

vercel bot commented Sep 10, 2024 •

edited

Loading