clean up playableChords logic

4lejandrito · Aug 9, 2022 · 811fc6b · 811fc6b
1 parent 71151d7
commit 811fc6b
Show file tree

Hide file tree

Showing 2 changed files with 5,482 additions and 22,195 deletions.
diff --git a/packages/react-guitar-fretter/src/index.ts b/packages/react-guitar-fretter/src/index.ts
@@ -85,7 +85,6 @@ export default function fretter(
   const isBarreChord = (fretting: number[]) => {
     const strippedFretting = fretting.filter((fret) => fret > 0)
     const duplicates = findDuplicates(strippedFretting)
-
     return (
       duplicates.length !== 0 &&
       duplicates.some(
@@ -98,15 +97,7 @@ export default function fretter(
   const playableChords = (fretting: number[]) => {
     const strippedFretting = fretting.filter((fret) => fret > 0)
     const duplicates = findDuplicates(strippedFretting)
-
-    // console.log(strippedFretting)
-
-    if (isOpenChord(fretting) && strippedFretting.length < 5) return true
-
-    return (
-      (strippedFretting.length >= 5 && !duplicates) ||
-      (duplicates && !isBarreChord(fretting))
-    )
+    return strippedFretting.length < 5 || (duplicates && isBarreChord(fretting))
   }
 
   const frettings = search<number[]>(