Document ERC-4337 specifics and learnings #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
reviewed
Oct 26, 2023
There was a problem hiding this comment.
The PR looks good to me. I wonder if it's right to state the incompatibility instead of checking how to improve it. Also, it could be our current implementation incompatibility and not the incompatibility of the broader spec since the specs do not define the storage. I raised this question on Slack.
nlordell
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
LGTM, I assume that this documentation will change with 5afe/safe-core-protocol#125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 5afe/safe-core-protocol#115
Changes in PR:
A short summary on why protocol specs are not compatible with ERC-4337. Content is taken from 5afe/safe-core-protocol#60. Thanks to @mmv08 . The PR omits any specific details on implementation as these are specs.