Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: state mutability and unused var #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gosuto-inzasheru
Copy link

Changes in PR:

  • perf: restrict state mutability to pure
  • perf: remove unused variable

implement performance recommendations from solidity compiler:

Warning: Unused local variable.
  --> contracts/test/TestFallbackReceiver.sol:13:24:
   |
13 |         (bool success, bytes memory data) = ethReceiver.call{value: address(this).balance}("");
   |                        ^^^^^^^^^^^^^^^^^


Warning: Function state mutability can be restricted to pure
   --> contracts/SafeProtocolRegistry.sol:122:5:
    |
122 |     function supportsInterface(bytes4 interfaceId) external view override returns (bool) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
   --> contracts/SignatureValidatorManager.sol:226:5:
    |
226 |     function supportsInterface(bytes4 interfaceId) external view override returns (bool) {
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
  --> contracts/test/TestPlugin.sol:21:5:
   |
21 |     function supportsInterface(bytes4 interfaceId) external view override returns (bool) {
   |     ^ (Relevant source part starts here and spans across multiple lines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant