Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Auto v1.9.3 #673

Merged
merged 3 commits into from
May 20, 2024
Merged

Update Auto v1.9.3 #673

merged 3 commits into from
May 20, 2024

Conversation

SachiaLanlus
Copy link
Contributor

@mashb1t
Copy link
Contributor

mashb1t commented Mar 5, 2024

LOL, i'm working on exactly this PR right now! Thanks a lot, no issues, works perfectly fine.
@SachiaLanlus EDIT there already is xformers==0.0.24 available, please check this one out and update

pip install pyngrok xformers==0.0.23.post1 \
accordingly.

@AbdBarho thank you for reviewing!

@SachiaLanlus
Copy link
Contributor Author

please check this one out and update

Auto still using the 0.0.23.post1.
Do you think we would be better to follow their favor or upgrade the newer as possible?
AUTOMATIC1111/stable-diffusion-webui@v1.7.0...v1.8.0#diff-b8454e8123e62f9ec2c0d4e299e0690c27592af4230a16976ecd4745e61871e7R343

@mashb1t
Copy link
Contributor

mashb1t commented Mar 5, 2024

Thanks for the feedback. Let's stick with their package versions to mirror them.

@darkvertex
Copy link

Out of curiosity what is the reason for removing the CodeFormer lines? Is it part of Auto now?

@SachiaLanlus
Copy link
Contributor Author

Out of curiosity what is the reason for removing the CodeFormer lines? Is it part of Auto now?

In the release note, they use Spandrel for upscaling and face restoration. Which is what CodeFormer be used for in the previous version.
You can check the code change here

@SachiaLanlus SachiaLanlus changed the title Update Auto v1.8.0 Update Auto v1.9.0 Apr 15, 2024
@SachiaLanlus
Copy link
Contributor Author

v1.9.0 is more like a chore fix.
There are lots of naming convention and code style change.
But the module dependencies do not change so just replace reference with newer tag and rebuild.

@SachiaLanlus SachiaLanlus changed the title Update Auto v1.9.0 Update Auto v1.9.3 Apr 24, 2024
Copy link
Contributor

@DevilaN DevilaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@picarica
Copy link

is this repo abondoned no activity nothing is being pulled

@mashb1t
Copy link
Contributor

mashb1t commented May 15, 2024

@AbdBarho what's the next step in this matter?

@DevilaN
Copy link
Contributor

DevilaN commented May 15, 2024

Probably somebody should just take over with fork and continue work.
The problem with this repo is that it tries to integrate many different UIs. It would be easier to split the work and focus solely on one UI. I could maintain A1111 as I use it on regular basis, but this changes nothing for this very repository :(

@mashb1t
Copy link
Contributor

mashb1t commented May 15, 2024

@DevilaN i have some changes in my fork for better handling of ComfyUI modules incl. being able to update them via Comfy manager on the fly without issues (as this repo doesn't support modules OOTB)

Copy link
Owner

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SachiaLanlus thank you very much for this! and sorry for being late.

@DevilaN I plan to split for the maintenance like you said.

@AbdBarho AbdBarho merged commit ac94eac into AbdBarho:master May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants