Finished Word-Guess Game.--by Erika & Ari

[arrriiii]

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
How do you feel you and your partner did in sharing responsibilities?	Initially, we didn't delegate responsibilities which made the process difficult but then when we started to talk out loud "rubberducking" it became easier to complete.
For each partner what parts of the project did you find challenging?	Erika- The parts I found most challenging were grasping the concept of classes and what go in them. It makes talking through it much more difficult. Ari- Because I didn't fully understand the concepts, it made it challenging to outline the steps to our program.
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs?	Our promptUser method allowed us to distinguish the users responds to our conditions -- and could be called after every condition.
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice?	We have the local variable 'level' instead of an instance variable because we wanted to determine the difficulty of the Game class--
What code, if any, did you feel like you were duplicating more than necessary?	Our pedal_remove method could have be consolidated with possible another method to remove petals-- instead of manually printing the flower design.
Is there a specific piece of code you'd like feedback on?	line 96-- we would like to know if there is an alternative format as our code can be confusing.

[droberts-sea]

Word-Guess Game

What We're Looking For

Feature	Feedback
Baseline
Regular Commits with meaningful commit messages.	N/A - looks like you used the old way of copy/paste code into GitHub instead of git push, so I cannot see your commit history
Readable code with consistent indentation.	your indentation could use some work, but variable names are descriptive and the flow is understandable
Answered comprehension questions	yes
Product Functionalities
Created a Class to encapsulate game functionality.	yes
Used methods to DRY up your code.	yes - would like to see a little more division of responsibility - see inline
Created instance variables & local variables where appropriate.	yes
Used Arrays to store lists of letters guessed.	yes
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers.	yes
Programmed "defensively" to detect errors in user input.	yes - good work

Good job overall! There's definitely some places where this code could be cleaned up, but in general this is a solid submission that meets the learning goals for this assignment. Let me know about questions on any of my comments below, and keep up the hard work!

[droberts-sea]

Watch your indentation here

[droberts-sea]

I suspect this is where your indentation gets messed up - Atom will want you to end the array on a new line.

             |___|'''.red
    ]
  end

[droberts-sea]

This portion, between lines 75 and 91, might be good to break out as a separate method, something like validate_guess.

[droberts-sea]

Please use do...end for loops, rather than curly braces.

[droberts-sea]

Ruby methods should be named using snake_case, so this one would be prompt_user.

[droberts-sea]

Here, promptUser calls itself, creating a sort of loop. A method calling itself is a programming technique called recursion, which you'll learn about in CS Fun in a few months.

Recursion is a powerful tool that can elegantly solve many problems. However, in this case I think a while loop might be a better choice, if only because it makes it immediately obvious to the reader that this code might execute many times.

[droberts-sea]

I don't think this call to pedal_remove is actually doing anything.

[droberts-sea]

I agree that this logic is a little dense. One observation is that we don't need the check on line 96, because if the correct word does not include the guess, then the if statement on line 98 will never go off.

We could simplify the whole section by rewriting it as:

letter_found = false
@correct_word_array.each_with_index do |letter, index|
  if letter == guess
    @correct_guess[index] = guess
    letter_found = true
  end
end

if letter_found
  puts "SECERT WORD: #{@correct_guess.join('  ')}"
  promptUser # return to the prompt method to guess another letter
else
  # ... the rest of this method, starting on line 105 ...
end