Karinna + Anne - RideShare Rails - Octos

[annehwatson]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We had a Trip class that belongs_to :driver and belongs_to :passenger and Passenger and Driver classes has_many :trips. We set it up that way because passengers were going to have multiple trips and drivers would have multiple trips but each trip would only have one driver and one passenger.
Describe the role of model validations in your application	Passengers and Drivers had to have names (validates :name, presence: true). For trips we validated that the trip had a driver (validates :driver, presence: true)
How did your team break up the work to be done?	We collaborated on most of the project and tried to drive and navigate together and switched roles throughout.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized the user stories by the ranking of importance provided in the assignment, with styling being the least important. We wanted to make sure that all of the business logic that was requested worked and that we were handling errors that the user might encounter.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Routes (included nesting and resources) made more sense after this project which helped with feeling more comfortable with the controllers.
What is your Trello URL?	https://trello.com/b/ludZJuD8/rideshare-rails
What is the Heroku URL of your deployed application?	https://frozen-stream-67491.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	Time management. Expectation setting and balancing priorities.

[kariabancroft]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Yes - looks good
Answered comprehension questions	Yes
Uses named routes (like _path)	Yes - though there are still a few manual route strings being used in the controller actions that should be updated to use the _path
RESTful routes utilized	Yes - looks good
Rideshare Rails Specific Content
Table relationships	Yes - relationships look good in the schema and the model files
Validation rules for Models	Yes - using presence validations
Business logic is in the models	Yes - doing some logic for the amounts and costs
Database is seeded from the CSV files	Yes - data on Heroku looks good
Trello board is created and utilized in project management	Yes - though its not public so I couldn't see it
Postgres database is used	Yes
Heroku instance is online	Yes
The app is styled to create an attractive user interface	Yes
Overall	Overall you did a good job hitting the major learning goals of this assignment. Watch out for opportunities to use the named routes (_path) in place of the "manual" string routes.