Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXGLDefaultMenu layout is not responsive #1021 #1356

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

DaleHuntGB
Copy link

@DaleHuntGB DaleHuntGB commented Feb 27, 2024

  • Position UI elements appropriately depending on appWidth size, ensuring it is a little more aesthetic and consistent across multiple previews.

This solves #1021.

Help from: @artemijsem & @BeckFW

@AlmasB
Copy link
Owner

AlmasB commented Feb 27, 2024

Thanks, looks good, there's an extra file in this PR that shouldn't have changed -- BuildProperties.java. Please check the files changed and remove it

@DaleHuntGB
Copy link
Author

Oh yeah, it would not build unless I copied it accordingly (not sure why that was the issue), am I safe to delete it from the PR? I didn't think it would have pushed this changed as I only staged the FXGLDefaultMenu

@AlmasB
Copy link
Owner

AlmasB commented Feb 27, 2024

@DaleHuntGB
Yes, it is an auto-generated file, which will be created during the build process. Safe to delete from the PR

Removed BuildProperties file.
@DaleHuntGB
Copy link
Author

@DaleHuntGB Yes, it is an auto-generated file, which will be created during the build process. Safe to delete from the PR

BuildProperties has been deleted from PR (I hope).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants