Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also outputs command output message when import fails on the update_primary_domain step. #2037

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

brunobasto
Copy link
Contributor

@brunobasto brunobasto commented Sep 19, 2024

Description

If the import failed on the update_primary_domain we wouldn't get details about the error and we would need to inspect the job logs to have an idea on why the job failed.

Pull request checklist

New release checklist

Steps to Test

  1. Check out PR.
  2. Run npm run build
  3. Run ./dist/bin/vip-import-sql.js -a 3800 sqlFile.sql -s
  4. Make sure the SQL contains a domain that is not mapped on the environment
  5. Check that you get error logs

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link
Member

@nickdaugherty nickdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@brunobasto brunobasto merged commit ddcba3f into trunk Sep 19, 2024
16 checks passed
@brunobasto brunobasto deleted the add/error-message-update-primary-domain branch September 19, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants