feature/#1858-add-s3-object-data-node

[AdeshGhadage]

This pull request addresses issue #1858.

Hello Maintainers,

Could you please review my code? I would appreciate any suggestions or feedback you might have.

Thank you!

[trgiangdo]

Hello @AdeshGhadage, thank you for your contribution.

The PR has well-handled the __AWS_REGION parameter.

And for the __AWS_S3_OBJECT_PARAMETERS, it is more complex since we need a more generic solution, which requires updating the configuration as well.

Please take a look at my comment and let me know what you think.

[trgiangdo]

Good progress.

The next step would be:

• updating the configuration for the S3ObjectDataNode here
• updating the docstring for the _configure_s3_object() method with new parameters.
• updating the docstring of the S3ObjectDataNode class. It should be very similar to the _configure_s3_object() method.

[AdeshGhadage]

@trgiangdo @jrobinAV Any other changes ? or some mistake I have made?

[trgiangdo]

Some final comments. Other than those, I think the PR is looking really good

[trgiangdo]

You also need to remove the _OPTIONAL_AWS_S3_OBJECT_PARAMETERS_PROPERTY in line 263 of the data_node_config.py file, and add the new OPTIONAL.. constant to the _STORAGE_TYPE_VALUE_S3_OBJECT dict (as pointed out by the linter)

[trgiangdo]

There are still some trailing spaces left in the code, as suggested by the linter here.

Other than that, I believe the PR is good to go, when all tests pass

[trgiangdo]

Hello @AdeshGhadage, thank you again for your contribution. The PR is ready to be merged.

However, due to the fact that Taipy is in the middle of a release, we will have to freeze all code changes for a few days.

In the meantime, feel free to take another issue to work on. We will merge this PR when the release is completed.