initial SIMD acceleration for the XOF (AVX-512-only, Unix-only) #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oconnor663
commented
Aug 18, 2024
c/blake3_dispatch.c
Outdated
| uint8_t out[64], size_t outblocks) { | ||
| #if defined(IS_X86) | ||
| const enum cpu_feature features = get_cpu_features(); | ||
| #if defined(__unix__) && !defined(BLAKE3_NO_AVX512) |
There was a problem hiding this comment.
@sneves what do you think about using __unix__ here?
There was a problem hiding this comment.
Considering that what is effectively being excluded here is Windows, maybe !defined(_WIN32) would make more sense. I believe Apple toolchains may not respect __unix__ and will define __APPLE__ or __MACH__ or something like that instead.
oconnor663
force-pushed
the
xof_integration_rebase
branch
2 times, most recently
from
cd1605e
to
9df48b4
Compare
oconnor663
force-pushed
the
xof_integration_rebase
branch
from
9df48b4
to
dcff6b6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this code has been around for a while on one branch or another, and this PR is a review before I push it to master. All of the assembly was written by @sneves.