build(CMake): Fix pkg-config for absolute CMAKE_INSTALL_*DIR #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurningEnlightenment
requested changes
Sep 6, 2024
CMAKE_INSTALL_*DIR can be absolute, and in that case ${prefix} should
not be prepended.
See https://github.com/jtojnar/cmake-snips/?tab=readme-ov-file#concatenating-paths-when-building-pkg-config-files
fgaz
force-pushed
the
pc-absolute-paths
branch
from
1169f56
to
7193667
Compare
BurningEnlightenment
approved these changes
Sep 6, 2024
|
Is there anything I can do to move this forward? |
|
If @oconnor663 doesn't say no until Friday, I'll go ahead and merge this. I don't think that his review is strictly necessary in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_INSTALL_*DIR can be absolute, and in that case ${prefix} should not be prepended.
See https://github.com/jtojnar/cmake-snips/?tab=readme-ov-file#concatenating-paths-when-building-pkg-config-files