Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGNN random metapath updated #175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wythedee
Copy link

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@wythedee
Copy link
Author

add a metapath_generator in MAGNN model

-------
Returns
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsuitable change.

edge_type_list = hg.etypes
metapath_list = []
metapath_list = metapath_list + metapath_generator(ntypes,edge_type_list,5,2)
metapath_list = metapath_list + metapath_generator(ntypes,edge_type_list,3,2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable named "in_feats“ ignored.

edge_type_list = hg.etypes
metapath_list = []
metapath_list = metapath_list + metapath_generator(ntypes,edge_type_list,5,2)
metapath_list = metapath_list + metapath_generator(ntypes,edge_type_list,3,2)
metapath_idx_dict = mp_instance_sampler(hg, metapath_list, 'imdb4MAGNN')
Copy link
Collaborator

@lazishu2000 lazishu2000 May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change line76 into
"metapath_idx_dict = mp_instance_sampler(hg, metapath_list, agrs.dataset)"

temp = temp + ntypes[random_index]
if temp not in metapath_list:
metapath_list.append(temp)
return metapath_list
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAGNN model request all metapath in metapath_list to be symmetric.
This function seems unable to do that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants