Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release candidate 2.0.1 #10

Merged
merged 16 commits into from
Aug 14, 2024
Merged

Release candidate 2.0.1 #10

merged 16 commits into from
Aug 14, 2024

Conversation

zsigmas
Copy link
Contributor

@zsigmas zsigmas commented Aug 13, 2024 •
edited by mattkorb
Loading

Critical checks

  • Is the version number correct?
  • Does the build pass?

Template

  • Is the template correctly used?
  • If modified is it commented accordingly?

Documentation

Does it include the following sections?

  • Module introduction with features
    • (O) Screenshots
  • Installation details
  • Explanation of function arguments
  • Explanation of input menus
  • Data specifications and requirements
  • Different possible visualizations
    • (O) Screenshots
  • (O) Short articles on building the app, compatibility with other modules, known bugs,...
  • Are the new features included in NEWS.md?

QC Report

  • Does it include a QC Report?

API conventions

  • Follows API convention

closes #8

zsigmas and others added 16 commits July 30, 2024 16:20
@zsigmas
Fix Selector Initialization Issue When Invoked from Another Module
8a9c34c 
When the selector is invoked from another module, it isn't ready yet, resulting in the selected subjid not being passed correctly.
@zsigmas
applies suspendWhenHidden FALSE to the selector container too
039f6e3
@zsigmas
Revert "Fix Selector Initialization Issue When Invoked from Another M…
92bdf17 
…odule"

This reverts commit 8a9c34c.
@zsigmas
Revert "applies suspendWhenHidden FALSE to the selector container too"
d122bfd 
This reverts commit 039f6e3.
@zsigmas
applies suspendWhenHidden = FALSE to all renderUIs to containers over…
0036995 
… selector

selectors is contained in 3 different renderUIs, selector, ui and dressing room
@zsigmas
styling
dc5e8a5
@zsigmas
remove debug messages
253a99e
@zsigmas
Revert "remove debug messages"
7b6d934 
This reverts commit 253a99e.
@zsigmas
remove debug messages
ecd6537
@zsigmas
add comments
4c522ce
@zsigmas
Merge pull request #3 from Boehringer-Ingelheim/fix/selector-initiali…
4f3e63e 
…zation-issue

Fix Selector Initialization Issue When Invoked from Another Module
@mattkorb
Enforce version number of plotly to be greater than 4.10.2
bb4b50d
@mattkorb
Change how the legend gets created if there is no grading variable
943593d
@zsigmas
Merge pull request #7 from Boehringer-Ingelheim/fix-open-issues
bea21b2 
Fix open issues
@zsigmas
styling
62ef00b
@zsigmas
bump version and NEWS
e7b07ae
@zsigmas zsigmas requested a review from mattkorb August 13, 2024 15:13
@zsigmas zsigmas self-assigned this Aug 13, 2024
@zsigmas zsigmas requested a review from a team as a code owner August 13, 2024 15:13
@zsigmas zsigmas merged commit 396d8e9 into main Aug 14, 2024
7 checks passed
@zsigmas zsigmas deleted the rc/2.0.1 branch August 14, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkorb mattkorb mattkorb approved these changes

Assignees

@zsigmas zsigmas

Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release 2.0.1
2 participants
@zsigmas @mattkorb