Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include qc report in a separate step #12

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

zsigmas
Copy link
Contributor

@zsigmas zsigmas commented Jun 3, 2024

I have created an alternative workflow where test and qc happen in separate steps.

The workflow runs all the steps as before with the following differences:

  • Check does no longer run the tests
  • test step also creates the validation report. This report is uploaded as an artifact in the test step.
  • pkgdown step waits for the tests to run, then it downloads the test report artifact and creates the documentation.

This PR does not address including the qc in the templates repo instead of the package repo. A different PR can be done for that issue.

  • Do not mind the repo and branch names in the workflow when ready to merge I will fix them.

include PAT

checkout templates
Copy link
Collaborator

@sorinvoicu sorinvoicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 , assuming we (still) want to keep the qc report bulk of code in each repo. (?)

@zsigmas
Copy link
Contributor Author

zsigmas commented Jun 3, 2024

I will fix the routes of the jobs and merge it. Extracting the QC report we can do in a following iteration. Thanks!

@zsigmas zsigmas marked this pull request as ready for review June 3, 2024 15:06
@zsigmas zsigmas merged commit bfb8601 into Boehringer-Ingelheim:main Jun 3, 2024
0 of 14 checks passed
@zsigmas zsigmas deleted the separate_steps_qc_pr branch June 3, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants