Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33 allow pipeline runs on every push #34

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

sorinvoicu
Copy link
Collaborator

closes #33

Don't think it is worth adding complexity like:
if: ${{ (github.ref_name == 'main' || github.ref_name == 'rc' ) && github.event_name == 'pull_request' }}

So I propose to still run the QC report steps on every push. Since the pipeline steps run in parallel there is no noticeable performance delay in doing this.

@sorinvoicu sorinvoicu requested a review from mattkorb July 4, 2024 21:43
@sorinvoicu sorinvoicu linked an issue Jul 4, 2024 that may be closed by this pull request
@mattkorb
Copy link

mattkorb commented Jul 5, 2024

closes #33

Don't think it is worth adding complexity like: if: ${{ (github.ref_name == 'main' || github.ref_name == 'rc' ) && github.event_name == 'pull_request' }}

So I propose to still run the QC report steps on every push. Since the pipeline steps run in parallel there is no noticeable performance delay in doing this.

Let's start with this, we can still add it if we think it suits more our needs.

@sorinvoicu sorinvoicu merged commit 0ab75e9 into main Jul 5, 2024
14 checks passed
@sorinvoicu sorinvoicu deleted the 33-allow-pipeline-runs-on-every-push branch July 5, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pipeline runs on every push
2 participants