Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract isUndo, isRedo into UndoRedo model #1205

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

chia-yh
Copy link
Contributor

@chia-yh chia-yh commented Aug 12, 2023

Summary:

Extract isUndo and isRedo into the UndoRedo model.

Originally part of the changes in #1197 . However, as #1197 is not being merged, these changes were extracted to this PR as they were viewed as good to have.

Changes Made:

  • isUndo, isRedo extracted into UndoRedo

Proposed Commit Message:

Extract isUndo, isRedo into UndoRedo model

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (1b6585f) 53.97% compared to head (2091b50) 53.93%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
- Coverage   53.97%   53.93%   -0.04%     
==========================================
  Files         101      101              
  Lines        2881     2881              
  Branches      534      534              
==========================================
- Hits         1555     1554       -1     
  Misses        984      984              
- Partials      342      343       +1     
Files Changed Coverage Δ
src/app/core/models/undoredo.model.ts 69.64% <0.00%> (-8.36%) ⬇️
.../shared/comment-editor/comment-editor.component.ts 16.84% <0.00%> (+0.53%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunweii chunweii merged commit 6b092b1 into CATcher-org:master Sep 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants