Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify_eigrp_interfaces_timers API to verify.py ios/iosxe eigrp protocol #165

Merged
merged 75 commits into from
Jul 15, 2024

Conversation

cherifimehdi
Copy link
Contributor

Hello,

I added verify_eigrp_interfaces_timers API to verify.py (my previous contribution) for ios/iosxe eigrp protocol.

I added the tests folder verify_eigrp_interfaces_timers at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/verify

I added the changelog_add_verify_eigrp_interfaces_timers_apis_202419041835 file at pkgs/sdk-pkg/changelog folder

Thank you for reviewing my contribution

cherifimehdi and others added 30 commits April 19, 2024 19:37
add mock for verify_eigrp_interfaces_timers
…verify_eigrp_interfaces_timers/mock_data/iosxe/test
Add test_api_verify_eigrp_interfaces_timers.py
Add verify_eigrp_interfaces_timers APIs for IOSXE/IOS EIGRP verify supporting ipv4 and ipv6 to my previous contribution verify.py
Add changelog_add_verify_eigrp_interfaces_timers_apis_202419041835
The change according to comments and suggestions
The change to add "show version | include operating mode: ''"
…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml
…verify_eigrp_interfaces_timers/mock_data/iosxe/tst
New with suggested modification
…verify_eigrp_interfaces_timers/mock_data/iosxe directory
…verify_eigrp_interfaces_timers/mock_data/iosxe/tst
…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml

Co-authored-by: Douglas Monteiro <[email protected]>
…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml

Co-authored-by: Douglas Monteiro <[email protected]>
New verify.py
New verify.py
@cherifimehdi
Copy link
Contributor Author

Hi @Taarini @SohanTirpude @lsheikal broken tests when I synced the fork to update the branch! please what is the problem?

@cherifimehdi
Copy link
Contributor Author

@Taarini @SohanTirpude @lsheikal any help...suggession...idea?

@cherifimehdi cherifimehdi reopened this Jun 8, 2024
@cherifimehdi
Copy link
Contributor Author

Hi @Taarini @SohanTirpude @lsheikal @ThomasJRyan I think there is a problem in pyATS after last update since tests keep fail after modification in PR

@cherifimehdi
Copy link
Contributor Author

Hello @Taarini @SohanTirpude @lsheikal still no answer and solution?

@cherifimehdi
Copy link
Contributor Author

Hi @SohanTirpude @Taarini @lsheikal Now test PASSED after I made update for my branch. I think there was a problem in the prvious version!

1 similar comment
@cherifimehdi
Copy link
Contributor Author

Hi @SohanTirpude @Taarini @lsheikal Now test PASSED after I made update for my branch. I think there was a problem in the prvious version!

@cherifimehdi
Copy link
Contributor Author

@Taarini approved my PR on May 31, please @lsheikal @SohanTirpude can you approve or review if there is anything else to modify cause it's been almost two months? THANKS

@cherifimehdi
Copy link
Contributor Author

Hi @lsheikal thank you for reviewing my PR. I applied your suggestion

@lsheikal lsheikal merged commit 9ee3d5c into CiscoTestAutomation:master Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants