Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(BookAndNotepad): Replace current svg with new cropped svg #2755

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

zippyzow
Copy link
Contributor

@zippyzow zippyzow commented Jul 11, 2023

Overview

The current illustration for the BookAndNotepad has extra space on the right side making it hard to center (see pics). Once we have the updated illustration, replace the current BookAndNotepad svg in gamut illustrations and then bump the monolith package so it gets the corrected illustration.

Before (note the extra space on the right)
Screenshot 2023-07-12 at 12 34 20 PM

After
Screenshot 2023-07-12 at 12 33 59 PM

PR Checklist

Testing Instructions

  1. Check out the BookAndNotepad under Illustrations in Storybook. You can see its more centered than the one in production which has extra space on the right.
  2. You can also go on the monolith PR env link, go to the dashboard as a user in the onboarding_getting_started experiment variant, and see the new illustration in action

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://64adce370d22f04c0a3c4b4f--gamut-preview.netlify.app

Deploy Logs

@zippyzow zippyzow requested review from a team, saghdaey and medhatnar and removed request for a team July 12, 2023 16:46
Copy link
Contributor

@saghdaey saghdaey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested in storybook preview & monolith preview

@zippyzow zippyzow added the Ship It :shipit: Automerge this PR when possible label Jul 12, 2023
@codecademydev codecademydev merged commit 3bcdfb4 into main Jul 12, 2023
22 of 23 checks passed
@codecademydev codecademydev deleted the hr-disc-1226-new-illustration-cropped branch July 12, 2023 18:05
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants