Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Modal): adding aria-live as a prop to ModalContainer #2762

Merged
merged 3 commits into from
Aug 1, 2023
Merged

feat(Modal): adding aria-live as a prop to ModalContainer #2762

merged 3 commits into from
Aug 1, 2023

Conversation

amabarr
Copy link
Contributor

@amabarr amabarr commented Jul 28, 2023 •
edited
Loading

Overview

As a part of this a11y ticket I was asked to turn off a modal's aria-live: A11Y-579, but I couldn't because it was hardcoded to "polite" in gamut. Here, I'm adding the ability to change the aria-live but also keeping "polite" as a default

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: A11Y-579
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. go to the preview LE below
  2. View a solution diff modal, see that it's aria-live is off in the help text
  3. Go anywhere else where there is a modal and see that it still has aria-live="polite"

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
LE link Same as Portal link above, but LE LE Env

@amabarr amabarr changed the title [A11Y-579] Adding the ability to turn off aria-live for modals feat(Modal) adding aria-live as a prop to ModalContainer Jul 28, 2023
@amabarr amabarr marked this pull request as ready for review July 28, 2023 17:08
@amabarr amabarr changed the title feat(Modal) adding aria-live as a prop to ModalContainer feat(Modal): adding aria-live as a prop to ModalContainer Jul 28, 2023
@amabarr amabarr requested review from a team, aresnik11 and dreamwasp and removed request for a team July 28, 2023 17:59
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://64c7bc45073d9900b2ec7e1d--gamut-preview.netlify.app

Deploy Logs

dreamwasp
dreamwasp approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chef's kiss perfect

@amabarr amabarr added the Ship It :shipit: Automerge this PR when possible label Aug 1, 2023
@codecademydev codecademydev merged commit e5d9543 into main Aug 1, 2023
12 of 13 checks passed
@codecademydev codecademydev deleted the ab-a11y-579-modal-aria-live branch August 1, 2023 17:09
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amabarr @codecademydev @dreamwasp