Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tooltip): add aria-described by to floating tooltip #2772

Merged
merged 8 commits into from
Sep 25, 2023
Merged

feat(Tooltip): add aria-described by to floating tooltip #2772

merged 8 commits into from
Sep 25, 2023

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Sep 8, 2023 •
edited
Loading

Overview

Swaps aria-label to aria-describedby for our floating ToolTip

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [web-2424]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Go to the Tooltip Story -> Placement section
  • Turn on VO
  • Tab to Floating Section
  • Should hear tooltips read when tabbing to buttons + info icons

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR <=
Portal Portal Link <=

@dreamwasp dreamwasp requested review from a team, jakemhiller and BandanaKM and removed request for a team September 8, 2023 15:45
@dreamwasp dreamwasp changed the title ToolTip JAWS QF feat(Tooltip): add aria-described by to floating tooltip Sep 8, 2023
@dreamwasp dreamwasp requested a review from a team as a code owner September 19, 2023 14:48
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6511920651dc6926caf8b6ef--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Sep 25, 2023
@codecademydev codecademydev merged commit 6caabd8 into main Sep 25, 2023
18 of 19 checks passed
@codecademydev codecademydev deleted the cass-web-2424-JAWS-fi branch September 25, 2023 14:01
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@timjenkins timjenkins timjenkins approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM was automatically assigned from Codecademy/web-platform

@aresnik11 aresnik11 Awaiting requested review from aresnik11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamwasp @codecademydev @jakemhiller @timjenkins