Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add listStyle props to Box and Column #2782

Merged
merged 8 commits into from
Nov 2, 2023
Merged

feat: add listStyle props to Box and Column #2782

merged 8 commits into from
Nov 2, 2023

Conversation

christian-dinh
Copy link
Contributor

@christian-dinh christian-dinh commented Sep 25, 2023 •
edited
Loading

Overview

add listStyle, listStyleType, listStyleImage, and listStylePosition props to Box and Column

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: REACH-3045
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • add listStyle, listStyleType, listStyleImage, and listStylePosition props to Column, Box, FlexBox, and GridBox components
  • ensure code passes type checker
  • ensure prop values are rendered as styles for the component

PR Links and Envs

Repository PR Link PR Env
Portal Portal Link Portal Env

@christian-dinh christian-dinh requested a review from a team as a code owner September 25, 2023 17:19
@christian-dinh christian-dinh requested review from a team, bndiep and jenesh and removed request for a team September 25, 2023 20:27
dreamwasp
dreamwasp reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this so much!!!!!

pending regression testing, my only ask is that you add a section in the CSS Props documentation (here)

dreamwasp
dreamwasp reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me and works like a charm, wonderful addition to our design system!! could you add test PR to the monolith? i just want to triple-check now weird type things happen there before you 🚢

@christian-dinh
Copy link
Contributor Author

Sorry for the delay, monolith PR is up!

https://github.com/codecademy-engineering/Codecademy/pull/36642

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://653fe0b8a7b51c009feef9b4--gamut-preview.netlify.app

Deploy Logs

dreamwasp
dreamwasp approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the awesome work + for being so tenacious with this pr ✨ excited for this to get shipped 😤

@dreamwasp dreamwasp self-requested a review November 2, 2023 13:20
dreamwasp
dreamwasp approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the awesome work + for being so tenacious with this pr ✨ excited for this to get shipped 😤

@christian-dinh christian-dinh added the Ship It :shipit: Automerge this PR when possible label Nov 2, 2023
@codecademydev codecademydev merged commit 77d2f13 into main Nov 2, 2023
19 of 21 checks passed
@codecademydev codecademydev deleted the cd-list-style branch November 2, 2023 17:36
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

@bndiep bndiep Awaiting requested review from bndiep bndiep was automatically assigned from Codecademy/dotcom

@jenesh jenesh Awaiting requested review from jenesh jenesh was automatically assigned from Codecademy/dotcom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christian-dinh @codecademydev @dreamwasp