Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Badge): updated Badge variants' color names #2793

Merged
merged 8 commits into from
Oct 24, 2023
Merged

refactor(Badge): updated Badge variants' color names #2793

merged 8 commits into from
Oct 24, 2023

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Oct 10, 2023 •
edited by dreamwasp
Loading

Overview

Addressing WEB-2446 --
Adjust dark-modegrey badges variants to meet WCAG contrast.

Expanded the scope to update all variants names, see figma attached:

PR Checklist

Testing Instructions

Load up storybook and find the badges page: http://localhost:6006/?path=/docs/atoms-badge--badge
The badges should still load just fine.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@LinKCoding LinKCoding changed the title Kl web 2446 refactor(Badge)!: updated Badge variants' color names Oct 16, 2023
@LinKCoding LinKCoding marked this pull request as ready for review October 19, 2023 14:23
@LinKCoding LinKCoding requested a review from a team as a code owner October 19, 2023 14:24
dreamwasp
dreamwasp requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just have a couple tweaks to the storybook story then should be ready to ship!

packages/styleguide/stories/Atoms/Badge.stories.mdx Outdated Show resolved Hide resolved
packages/styleguide/stories/Atoms/Badge.stories.mdx Outdated Show resolved Hide resolved
dreamwasp
dreamwasp approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@dreamwasp dreamwasp changed the title refactor(Badge)!: updated Badge variants' color names refactor(Badge): updated Badge variants' color names Oct 24, 2023
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Oct 24, 2023
@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6537da6f26768805d4b9f768--gamut-preview.netlify.app

Deploy Logs

@codecademydev codecademydev merged commit ee1b395 into main Oct 24, 2023
18 of 19 checks passed
@codecademydev codecademydev deleted the kl-web-2446 branch October 24, 2023 14:53
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

Assignees

@dreamwasp dreamwasp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinKCoding @codecademydev @dreamwasp