Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add webpack as a dev dependency #2796

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix: add webpack as a dev dependency #2796

merged 2 commits into from
Jan 17, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Oct 23, 2023 •
edited
Loading

Overview

Resolves yarn + webpack issues

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Storybook should run locally

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very sorry for dropping the ball on this! But yes 💯 this fixes things on my M1 Max Mac Mini! yarn, yarn build, and yarn start all work as expected now. The localhost Storybook preview looks exactly as I (fondly) remember it. Thanks!

@dreamwasp dreamwasp marked this pull request as ready for review January 17, 2024 19:16
@dreamwasp dreamwasp requested a review from a team as a code owner January 17, 2024 19:16
jakemhiller
jakemhiller approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, fun!

@dreamwasp dreamwasp changed the title try fixing webpack issues fix: add webpack as a dev dependency Jan 17, 2024
@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://65a8295a241cb406d446ebc4--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Jan 17, 2024
@codecademydev codecademydev merged commit 3f4612c into main Jan 17, 2024
25 of 30 checks passed
@codecademydev codecademydev deleted the cass-web-webpack branch January 17, 2024 20:20
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamwasp @codecademydev @jakemhiller @JoshuaKGoldberg