Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): add miniCopyIcon #2806

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat(Icons): add miniCopyIcon #2806

merged 1 commit into from
Nov 9, 2023

Conversation

akshaydmc
Copy link
Contributor

Overview

Add miniCopyIcon, For now we are using this icon in prompt engineering component for copying code from codeblocks.

Screenshot 2023-11-09 at 4 36 54 PM

PR Checklist

  • Related to designs: figma
  • Related to JIRA ticket: LABS-61
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@akshaydmc akshaydmc requested a review from a team as a code owner November 9, 2023 11:29
dreamwasp
dreamwasp approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@akshaydmc akshaydmc added the Ship It :shipit: Automerge this PR when possible label Nov 9, 2023
@codecademydev codecademydev merged commit 24aee8c into main Nov 9, 2023
20 of 22 checks passed
@codecademydev codecademydev deleted the ak-mini-copy-icon branch November 9, 2023 18:22
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaydmc @dreamwasp @codecademydev