Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): add bookBookmarkIcon #2810

Merged
merged 8 commits into from
Nov 30, 2023
Merged

feat(Icons): add bookBookmarkIcon #2810

merged 8 commits into from
Nov 30, 2023

Conversation

sooinc
Copy link
Contributor

@sooinc sooinc commented Nov 30, 2023 •
edited
Loading

Overview

  • add bookBookmarkIcon (to be used in the new dashboard page for My learning nav)
Screenshot 2023-11-30 at 9 20 04 AM

PR Checklist

Testing Instructions

  1. Go to the Storybook icon preview
  2. Search for BookBookmarkIcon

PR Links and Envs

Repository PR Link PR Env
Portal Portal Link Portal Env

@sooinc sooinc requested a review from a team as a code owner November 30, 2023 14:23
dreamwasp
dreamwasp approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://656901e5a883aa110b591530--gamut-preview.netlify.app

Deploy Logs

@sooinc sooinc added the Ship It :shipit: Automerge this PR when possible label Nov 30, 2023
@codecademydev codecademydev merged commit 4c0f6ff into main Nov 30, 2023
19 of 20 checks passed
@codecademydev codecademydev deleted the sc-book-bookmark-icon branch November 30, 2023 21:44
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sooinc @codecademydev @dreamwasp