Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Illustration): add Interview illustration #2811

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

natalieweesh
Copy link
Contributor

@natalieweesh natalieweesh commented Dec 6, 2023

Overview

add Interview illustration

Screenshot 2023-12-05 at 5 13 01 PM

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Portal Portal PR Monolith Env

@natalieweesh natalieweesh changed the title add Interview illustration feat(Illustration): add Interview illustration Dec 6, 2023
height,
width,
}) => (
<svg aria-hidden={ariaHidden}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like prettier wasn't run on this file, this usually happens automagically on save 🤔 i'll check out our settings and see if anything seems amiss, in the meantime you can run yarn nx format:write --packages/gamut-illustrations/src/Interview.tsx to get it to happen manually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh thanks! updated 👍

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6570bd17b8bd6f03182b88a7--gamut-preview.netlify.app

Deploy Logs

@natalieweesh natalieweesh added the Ship It :shipit: Automerge this PR when possible label Dec 6, 2023
@codecademydev codecademydev merged commit 36be223 into main Dec 6, 2023
22 of 23 checks passed
@codecademydev codecademydev deleted the nw-lego-3602-interview-illustration branch December 6, 2023 18:59
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants