Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): add EmailFilledIcon, WhatsAppIcon, and XIcon #2825

Merged
merged 2 commits into from
Jan 10, 2024
Merged

feat(Icons): add EmailFilledIcon, WhatsAppIcon, and XIcon #2825

merged 2 commits into from
Jan 10, 2024

Conversation

bndiep
Copy link
Contributor

@bndiep bndiep commented Jan 9, 2024 •
edited
Loading

Overview

Adds EmailedFilledIcon and vendor icons WhatsAppIcon and XIcon

PR Checklist

Testing Instructions

  1. Use the Storybook preview to view the new icons
  2. Ensure the icons look good in the preview
  • EmailFilledIcon will be under "Interface Icons"
  • WhatsAppIcon and XIcon will be under "Vendor Icons"

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Portal Portal Link Portal Env

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://659dd43f514f1b65c092c3c6--gamut-preview.netlify.app

Deploy Logs

@bndiep bndiep marked this pull request as ready for review January 10, 2024 16:23
@bndiep bndiep requested a review from a team as a code owner January 10, 2024 16:23
@bndiep bndiep added the Ship It :shipit: Automerge this PR when possible label Jan 10, 2024
@codecademydev codecademydev merged commit 83c138a into main Jan 10, 2024
28 of 29 checks passed
@codecademydev codecademydev deleted the bd.social-share-and-email-filled-icons branch January 10, 2024 18:27
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjenkins timjenkins timjenkins approved these changes

@dreamwasp dreamwasp Awaiting requested review from dreamwasp dreamwasp is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bndiep @codecademydev @timjenkins