Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Menu): add optional menu role #2828

Merged
merged 8 commits into from
Jan 26, 2024
Merged

feat(Menu): add optional menu role #2828

merged 8 commits into from
Jan 26, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Jan 17, 2024 •
edited
Loading

Overview

Add role as an optional prop to Menu + clarifying documentation on when the menu role should be used.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: WEB-2513
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Navigate to the Menu storybooks
  • Look at all the nice new documentation
  • Inspect the default Menus - see they do not have the menu role and their children do not have the menuitem role.
  • Inspect the popover menu - it should have the menu role and it's childrn should have the menuitem role.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Monorepo Monorepo Link Portal Env

@dreamwasp dreamwasp marked this pull request as ready for review January 19, 2024 21:09
@dreamwasp dreamwasp requested a review from a team as a code owner January 19, 2024 21:09
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://65b3ee281dcea23f4149acab--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Jan 26, 2024
@codecademydev codecademydev merged commit f3efc3f into main Jan 26, 2024
18 of 19 checks passed
@codecademydev codecademydev deleted the cass-web-2513 branch January 26, 2024 17:39
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjenkins timjenkins timjenkins approved these changes

@BandanaKM BandanaKM BandanaKM approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamwasp @codecademydev @timjenkins @BandanaKM