Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): add new icons miniThumbsUpIcon and miniThumbsDownIcon #2865

Merged
merged 1 commit into from
Apr 18, 2024
Merged

feat(Icons): add new icons miniThumbsUpIcon and miniThumbsDownIcon #2865

merged 1 commit into from
Apr 18, 2024

Conversation

akshaydmc
Copy link
Contributor

@akshaydmc akshaydmc commented Apr 18, 2024 •
edited
Loading

Overview

Add new icon miniThumbsUpIcon and miniThumbsDownIcon for AI Feature Reconciliation.
Figma:- https://www.figma.com/file/AMM6cj988fxhTGiQFKw5nL/%F0%9F%8C%80-AI-features-reconciliation?type=design&node-id=1-2927&mode=design&t=5SBDpOJWxWtbqZY2-4

Screenshot 2024-04-18 at 2 24 12 PM

PR Checklist

  • Related to designs:
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@akshaydmc akshaydmc requested a review from a team as a code owner April 18, 2024 08:54
@akshaydmc akshaydmc changed the title add miniThumbsUpIcon and miniThumbsDownIcon feat(Icons): add new icons miniThumbsUpIcon and miniThumbsDownIcon Apr 18, 2024
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6620e1e65fc4e61d975038b6--gamut-preview.netlify.app

Deploy Logs

@akshaydmc akshaydmc added the Ship It :shipit: Automerge this PR when possible label Apr 18, 2024
@codecademydev codecademydev merged commit 12cfac3 into main Apr 18, 2024
33 of 36 checks passed
@codecademydev codecademydev deleted the ak-mini-thumbs-icons branch April 18, 2024 18:44
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaydmc @codecademydev @dreamwasp