perf: Cherry-pick Lodash imports for smaller bundles #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrood
changed the title
jrood
force-pushed
the
jrood.lodash-cherry-pick-imports
branch
3 times, most recently
from
0071d2e
to
ef0343d
Compare
jakemhiller
reviewed
May 1, 2024
There was a problem hiding this comment.
- I love this
- what do you think about adding
eslint-plugin-lodashand linting this, so it doesn't get reversed in the future?
in the root .eslintrc.json
{
...
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
"plugins": ["lodash"],
"rules": {
"lodash/import-scope": ["error", "method-package"],
...
ooh, yes I'll add that! |
jrood
force-pushed
the
jrood.lodash-cherry-pick-imports
branch
from
f1f5dfe
to
4bbac12
Compare
jrood
commented
May 1, 2024
| files: ['*.ts', '*.tsx', '*.js', '*.jsx'], | ||
| plugins: ['lodash'], | ||
| rules: { | ||
| 'lodash/import-scope': ['error', 'method'], |
There was a problem hiding this comment.
I used method rather than method-package here for lodash/map rather than lodash.map
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use Cherry-picked Lodash imports for smaller bundles
PR Checklist
Related to designs:Related to JIRA ticket: [ABC-123]This PR includes unit tests for the code changeThis PR includes testing instructions tests for the code changePR Links and Envs