fix(Button): remove button as default role

packages/gamut/src/ButtonBase/ButtonBase.tsx

@@ -77,7 +77,7 @@ export const ButtonBase = forwardRef<
         ref={ref as MutableRefObject<HTMLButtonElement>}
         as="button"
         type={type}
-        role={role ?? 'button'}
+        role={role}
         disabled={!!disabled}
       >
         {children}

packages/gamut/src/ButtonBase/__tests__/ButtonBase.test.tsx

@@ -0,0 +1,56 @@
+import { setupRtl } from '@codecademy/gamut-tests';
+
+import { ButtonBase } from '../ButtonBase';
+
+const buttonText = 'Submit';
+
+const renderView = setupRtl(ButtonBase, {
+  children: buttonText,
+});
+
+describe('ButtonBase', () => {
+  it('renders itself and children', () => {
+    const { view } = renderView();
+
+    view.getByText(buttonText);
+    view.getByRole('button');
+  });
+
+  it('renders an anchor tag if the href prop is used', () => {
+    const { view } = renderView({ href: 'https://www.codecademy.com' });
+
+    view.getByText(buttonText);
+    view.getByRole('link');
+  });
+
+  it('renders an anchor tag if a blank href prop is used', () => {
+    const { view } = renderView({ href: '' });
+
+    view.getByText(buttonText);
+    view.getByRole('link');
+  });
+
+  it('renders a button with the correct role', () => {
+    const { view } = renderView({ role: 'menuitem' });
+
+    view.getByText(buttonText);
+    view.getByRole('menuitem');
+  });
+
+  describe('when the button is disabled', () => {
+    it('does not render the href attribute and renders a button', () => {
+      const { view } = renderView({ disabled: true });
+
+      const el = view.getByText(buttonText);
+      view.getByRole('button');
+      expect(el.getAttribute('href')).toBeNull();
+    });
+
+    it('renders the disabled attribute on button tags', () => {
+      const { view } = renderView({ disabled: true });
+
+      const el = view.getByText(buttonText);
+      expect(el.getAttribute('disabled')).toBe('');
+    });
+  });
+});

packages/styleguide/stories/Atoms/Button/index.stories.mdx

@@ -26,7 +26,6 @@ import { ButtonScale } from './examples';
   args={{
     children: 'Click Me',
     disabled: false,
-    href: '',
     size: 'normal',
   }}
   parameters={{